<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 13, 2018 at 11:12 AM, Shyam Ranganathan <span dir="ltr"><<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On 02/13/2018 12:35 AM, Atin Mukherjee wrote:<br>
><br>
><br>
> On Tue, Feb 13, 2018 at 10:43 AM, Jiffin Tony Thottan<br>
</span><span class="gmail-">> <<a href="mailto:jthottan@redhat.com">jthottan@redhat.com</a> <mailto:<a href="mailto:jthottan@redhat.com">jthottan@redhat.com</a>>> wrote:<br>
><br>
> Since the change was there from 3.10 onwards, only upgrade from<br>
> eoled version to stable will break right?<br>
><br>
> I didn't notice anyone complaining about the issue in community till<br>
> now.<br>
><br>
><br>
> If any one upgrades the cluster from < 3.10 to >= 3.10, it's a genuine<br>
> problem as per my code reading.</span> <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
</span>So I tested 3.9 -> 3.10 -> 3.12 -> 3.13 upgrades (during release times).<br>
Actually n-1 to n where 'n' is the current release.<br></blockquote><div><br><div><br></div>I looked into this a bit more and found what's
happening here. If you test the upgrade path where target version is
<3.10.8 or 3.13.0 or 3.12.3 from < 3.10 you're good. This bug was
made exposed because of the fix for the bug I pointed out below. Post
upgrade when bricks restart, the patch of the below fix was dumping the
volinfo into the disk because of which even if the cluster.op-version is
not bumped up then we expose this issue.<br><br>glusterfs-3.10.8 - <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1507752">https://bugzilla.redhat.com/show_bug.cgi?id=1507752</a><br>glusterfs-3.13.0 - <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1506589">https://bugzilla.redhat.com/show_bug.cgi?id=1506589</a><br>glusterfs-3.12.3 - <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1507748">https://bugzilla.redhat.com/show_bug.cgi?id=1507748</a> <br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
What I do *not* test is every option that can be enabled, and the<br>
resultant upgrade scenario. (which I believe we should do)<br></blockquote><div><br></div><div>For this case, we didn't need to explicitly turn on any option. Its just that a new in-memory field which was introduced in volinfo which gets written to the disk.<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
What is the shortest way to at *least* test,<br>
- added options<br>
- changed options<br>
for a release?<br>
<span class="gmail-"><br>
><br>
><br>
> --<br>
><br>
> Jiffin<br>
><br>
><br>
><br>
> On Tuesday 13 February 2018 08:21 AM, Hari Gowtham wrote:<br>
><br>
> I'm working on it.<br>
><br>
> On Tue, Feb 13, 2018 at 8:11 AM, Atin Mukherjee<br>
</span><span class="gmail-">> <<a href="mailto:amukherj@redhat.com">amukherj@redhat.com</a> <mailto:<a href="mailto:amukherj@redhat.com">amukherj@redhat.com</a>>> wrote:<br>
><br>
> FYI.. We need to backport<br>
> <a href="https://review.gluster.org/#/c/19552" rel="noreferrer" target="_blank">https://review.gluster.org/#/<wbr>c/19552</a><br>
> <<a href="https://review.gluster.org/#/c/19552" rel="noreferrer" target="_blank">https://review.gluster.org/#/<wbr>c/19552</a>> (yet to be<br>
> merged in mainline) in all the active release branches to<br>
> avoid users to get<br>
> into upgrade failures. The bug and the commit has the<br>
> further details.<br>
><br>
><br>
><br>
><br>
><br>
><br>
><br>
</span>> ______________________________<wbr>_________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
> <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
><br>
</blockquote></div><br></div></div>