<div dir="ltr"><div><br><div class="gmail_quote"><div dir="auto">On Mon, 15 Jan 2018 at 12:15, Nithya Balachandran &lt;<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Hi,<div><br></div><div>A few questions about this:</div><div><br></div><div>1. What (if anything) should be done for options like these which have &quot;!&quot; ?</div><div><br></div><div><div>        /* Switch xlator options (Distribute special case) */                   </div><div>        { .key        = &quot;cluster.switch&quot;,                                       </div><div>          .voltype    = &quot;cluster/distribute&quot;,                                   </div><div>          .option     = &quot;!switch&quot;,                                              </div><div>          .type       = NO_DOC,                                                 </div><div>          .op_version = 3,                                                      </div><div>          .flags      = VOLOPT_FLAG_CLIENT_OPT                                  </div><div>        }, </div></div><div><br></div></div></blockquote><div><br></div><div>The options starting with bang doesn&#39;t get loaded with all the graphs and have special handling in glusterd-volgen code. I think we&#39;d need these type of options handled specially in GD2&#39;s volgen as well, Aravinda? From the option perspective, I think we need to just copy the same option (with bang) in the respective xlators.</div><div><br></div><div>Kaushal/Aravinda - Please do confirm.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><br></div><div><br></div><div>2. How should the changed key names handled?</div><div><br></div><div>In glusterd:</div><div><br></div><div><div>        { .key        = &quot;cluster.switch-pattern&quot;,                               </div><div>          .voltype    = &quot;cluster/switch&quot;,                                       </div><div>          .option     = &quot;pattern.switch.case&quot;,                                  </div><div>          .type       = NO_DOC,                                                 </div><div>          .op_version = 3,                                                      </div><div>          .flags      = VOLOPT_FLAG_CLIENT_OPT                                  </div><div>        }, </div></div><div><br></div><div><br></div><div>In dht src code:</div><div><div>        /* switch option */                                                     </div><div>        { .key  = {&quot;pattern.switch.case&quot;},                                      </div><div>          .type = GF_OPTION_TYPE_ANY,                                           </div><div>          .op_version = {3},                                                    </div><div>          .flags = OPT_FLAG_CLIENT_OPT,                                         </div><div>        },</div></div><div></div></div></blockquote><div dir="auto"><br></div><div dir="auto">We need to have both the patterns in the key as comma separated.</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><br></div><div><br></div><div><br></div><div>Regards,</div><div>Nithya</div><div><br></div></div>
</blockquote></div></div></div>