<div dir="ltr">That's true Joe. Ideally the commit should explain the reason of why it was reverted. I believe Milind is already working on this problem and he should be able to revive back the patch with the changes required to let all the tests pass.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 8, 2018 at 8:49 AM, Joe Julian <span dir="ltr"><<a href="mailto:joe@julianfamily.org" target="_blank">joe@julianfamily.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>The point is, I believe, that one shouldn't have to go digging
through external resources to find out why a commit exists. Please
ensure the commit message has adequate accurate information.<br>
</p><div><div class="h5">
<br>
<div class="m_4360258077827032649moz-cite-prefix">On 01/07/2018 07:11 PM, Atin Mukherjee
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Also please refer <a href="http://lists.gluster.org/pipermail/gluster-devel/2017-December/054103.html" target="_blank">http://lists.gluster.org/<wbr>pipermail/gluster-devel/2017-<wbr>December/054103.html</a>
. Some of the tests like ssl-cipher.t, trash.t were failing
frequently in brick multiplexing enabled regression jobs. When I
reverted this patch, I couldn't reproduce any of those test
failures.<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Jan 8, 2018 at 8:36 AM, Nithya
Balachandran <span dir="ltr"><<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote"><span>On 7 January
2018 at 18:54, Jeff Darcy <span dir="ltr"><<a href="mailto:jeff@pl.atyp.us" target="_blank">jeff@pl.atyp.us</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There's
no explanation, or reference to one, in the commit
message. In the comments, there's a claim that
seems a bit exaggerated.<br>
<br>
> This is causing almost all the regressions to
fail. durbaility-off.t is the most affected test.<br>
</blockquote>
<div><br>
</div>
</span>
<div>This patch does seem to be the cause. Running
this test in a loop on my local system with the
patch caused it to fail several times (it is an
intermittent failure). The test passed every time
after I tried the same after reverting the patch.
When it fails, it is because the mount process does
not connect to all bricks.</div>
<span>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
This patch was merged on December 13. Regressions
have passed many times since then. If almost all
regressions have started failing recently, I
suggest we look for a more recent cause. For
example, if this was collateral damage from
debugging the dict-change issue, then the patch
should be reinstated (which I see has not been
done). Alternatively, is the above supposed to
mean that this patch has been observed to cause
*occasional* failures in many other tests? If so,
which tests and when? There's no way to search for
these in Gerrit or Jenkins. If specific logs or
core-dump analyses point toward this conclusion
and the subsequent action, then it would be very
helpful for those to be brought forward so we can
debug the underlying problem. That's likely to be
hard enough without trying to do it blind.<br>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><br>
</blockquote>
</span></div>
<br>
</div>
</div>
<br>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="m_4360258077827032649mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
Gluster-devel mailing list
<a class="m_4360258077827032649moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a>
<a class="m_4360258077827032649moz-txt-link-freetext" href="http://lists.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a></pre>
</blockquote>
<br>
</div></div></div>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br></div>