<div dir="ltr">As per your review comments, introduced GF_ABORT as part of patch <a href="https://review.gluster.org/#/c/18309/5">https://review.gluster.org/#/c/18309/5</a><div><br></div><div>I wouldn't get into changing anything with ASSERT at the moment, as there are around ~2800 instances :-o</div><div><br></div><div>Wherever it is critical, lets call 'GF_ABORT()' in future, and also we should have a '<a href="http://checkpatches.pl">checkpatches.pl</a>' check to warn people about usage of GF_ABORT().</div><div><br></div><div>Regards,</div><div>Amar</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 3, 2017 at 2:05 PM, Xavi Hernandez <span dir="ltr"><<a href="mailto:jahernan@redhat.com" target="_blank">jahernan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi all,<div><br></div><div>I've seen that GF_ASSERT() macro is defined in different ways depending on if we are building in debug mode or not.</div><div><br></div><div>In debug mode, it's an alias of assert(), but in non-debug mode it simply logs an error message and continues.</div><div><br></div><div>I think that an assert should be a critical check that should always be true, specially in production code. Allowing the program to continue after a failure on one of these checks is dangerous. Most probably it will crash later, losing some information about the real cause of the error. But even if it doesn't crash, some internal data will be invalid, leading to a bad behavior.</div><div><br></div><div>I think we should always terminate the process if an assertion fails, even in production level code. If some failure is not considered so much critical by the coder, it should not use GF_ASSERT() and only write a log message or use another of the condition check macros.</div><div><br></div><div>Thoughts ?</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Xavi</div></font></span></div>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div>