<div dir="ltr"><b>Squashed Patches</b><br>I believe, individual engineers have to own the responsibility of maintaining history of all appropriate Change-Ids as part of the commit message when multiple patches have been squashed/merged into one commit.<br><br><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu <span dir="ltr"><<a href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello folks,<br>
<br>
A few times, we've merged dependent patches out of order because the Submit<br>
type[1] did not block us from doing so. The last few times we've talked about<br>
this, we didn't actually take a strong decision either way. In yesterday's<br>
maintainers meeting, we agreed to change the Submit type to<br>
Rebase-If-Necessary. This change will happen on 18th September 2017.<br>
<br>
What this means:<br>
* No more metadata flags added by Gerrit. There will only be a Change-Id,<br>
Signed-off-by, and BUG (if you've added it). Gerrit itself will not add any<br>
metadata.<br>
* If you push a patch on top of another patch, the Submit button will either be<br>
grayed out because the dependent patches cannot be merged or they will be<br>
submited in the correct order in one go.<br>
<br>
Some of the concerns that have been raised:<br>
Q: With the Reviewed-on flag gone, how do we keep track of changesets<br>
(especially backports)?<br>
A: The Change-Id will get you all the data directly on Gerrit. As long you<br>
retain the Change-Id, Gerrit will get you the matching changesets.<br>
<br>
Q: Will who-wrote-what continue to work?<br>
A: As far as I can see, it continues to work. I ran the script against<br>
build-jobs repo and it works correctly. Additionally, we'll be setting up an<br>
instance of Gerrit Stats[2] to provide more detailed stats.<br>
<br>
Q: Can we have some of the metadata if not all?<br>
Q: Why can't we have the metadata if we change the submit type?<br>
A: There's no good answer to this other than, this is how Gerrit works and<br>
I can neither change it nor control it.<br>
<br>
[1]: <a href="https://review.gluster.org/Documentation/intro-project-owner.html#submit-type" rel="noreferrer" target="_blank">https://review.gluster.org/<wbr>Documentation/intro-project-<wbr>owner.html#submit-type</a><br>
[2]: <a href="http://gerritstats-demo.firebaseapp.com/" rel="noreferrer" target="_blank">http://gerritstats-demo.<wbr>firebaseapp.com/</a><br>
<br>
--<br>
nigelb<br>
______________________________<wbr>_________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/maintainers</a><br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Milind<br><br></div></div></div></div>
</div>