<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 7, 2017 at 12:33 PM, Krutika Dhananjay <span dir="ltr"><<a href="mailto:kdhananj@redhat.com" target="_blank">kdhananj@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div>The patch[1] that introduced tests/basic/stats-dump.t was merged in October 2015 and<br>my patch underwent (and passed too![2]) centos regression tests, including stats-dump.t on 05 June, 2017.<br></div>The only change that the test script underwent during this time was this line in 2016, which is harmless:<br><br>a4f84d78 (Kaleb S KEITHLEY 2016-03-15 06:16:31 -0400 17) EXPECT_WITHIN $NFS_EXPORT_TIMEOUT "1" is_nfs_export_available<br><br></div>So there was NO change that went between 5th June and the time my patch was merged, which could have broken the test suite, that could have been caught easily with a mere rebase? Or am I missing something here? The problem is simply that the test script didn't fail on my patch.<br></div></div></div></blockquote><div><br></div><div>It's not the test but probably something in the code which has gone in to make this test fail now. So no way it's something the developer/maintainer has to take a blame for. <br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div><div><br></div><br>[1] - <a href="https://review.gluster.org/12209" target="_blank">https://review.gluster.org/<wbr>12209</a><br>[2] - <a href="https://build.gluster.org/job/centos6-regression/4897/consoleFull" target="_blank">https://build.gluster.org/job/<wbr>centos6-regression/4897/<wbr>consoleFull</a><span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888">-Krutika <br></font></span></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Fri, Jul 7, 2017 at 9:51 AM, Atin Mukherjee <span dir="ltr"><<a href="mailto:amukherj@redhat.com" target="_blank">amukherj@redhat.com</a>></span> wrote:<br></span><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Krutika,<br><br></div>tests/basis/stats-dump.t is failing all the time and as per my initial analysis after <a href="https://review.gluster.org/#/c/17709/" target="_blank">https://review.gluster.org/#/c<wbr>/17709/</a> got into the mainline the failures are seen and reverting this patch makes the test to run successfully. I do understand that the centos vote for this patch was green but the last run was on 5th June which was 1 month back. So some other changes have gone into in between which is now causing this patch to break the test.<br><br></div>This makes me think as a maintainer we do need to ensure the if the regression vote on the patch is quite old, a rebase of the patch is must to be on the safer side?<span class="m_5934514245616789998HOEnZb"><font color="#888888"><br><br></font></span></div><span class="m_5934514245616789998HOEnZb"><font color="#888888">~Atin<br></font></span></div>
</blockquote></div></div></div><br></div>
</blockquote></div><br></div></div>