<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 7, 2017 at 9:51 AM, Atin Mukherjee <span dir="ltr"><<a href="mailto:amukherj@redhat.com" target="_blank">amukherj@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Krutika,<br><br></div>tests/basis/stats-dump.t is failing all the time and as per my initial analysis after <a href="https://review.gluster.org/#/c/17709/" target="_blank">https://review.gluster.org/#/<wbr>c/17709/</a> got into the mainline the failures are seen and reverting this patch makes the test to run successfully. I do understand that the centos vote for this patch was green but the last run was on 5th June which was 1 month back. So some other changes have gone into in between which is now causing this patch to break the test.<br><br></div>This makes me think as a maintainer we do need to ensure the if the regression vote on the patch is quite old, a rebase of the patch is must to be on the safer side?<span class="HOEnZb"><font color="#888888"><br><br></font></span></div></div></blockquote><div><br>Not sure if it is feasible. All we can do is, if its confirmed that a given patch is caused the issue, we should revert it (manually or automatically), and let the author/maintainer now about the revert. I guess it should be part of the work-flow so we don't have to bother about figuring out whose responsibility it is.<br><br></div><div>Open to hear more suggestions here.<br><br></div><div>-Amar<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><span class="HOEnZb"><font color="#888888"></font></span></div><span class="HOEnZb"><font color="#888888">~Atin<br></font></span></div>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div>