<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 27, 2017 at 12:25 PM, Kotresh Hiremath Ravishankar <span dir="ltr"><<a href="mailto:khiremat@redhat.com" target="_blank">khiremat@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi,<br><br></div>We were looking for faster non-cryptographic hash to be used for the gfid2path infra [1]<br>The initial testing was done with md5 128bit checksum which was a slow, cryptographic hash<br></div><div>and using it makes software not complaint to FIPS [2]<br></div><br></div><div>On searching online a bit we found out xxhash [3] seems to be faster from the results of <br>benchmark tests shared and lot of projects use it. So we have decided to us xxHash<br>and added following files to gluster code base with the patch [4]<br><br> BSD 2-Clause License:<br> contrib/xxhash/xxhash.c<br> contrib/xxhash/xxhash.h<br><br> GPL v2 License:<br> tests/utils/xxhsum.c<br><br></div><div>NOTE: We have ignored the code guideline check for these files as maintaining it <br></div><div>further becomes difficult.<br></div><div><br></div><div>Please comment on the same if there are any issues around it.<br></div><div><br>[1] Issue: <a href="https://github.com/gluster/glusterfs/issues/139" target="_blank">https://github.com/gluster/<wbr>glusterfs/issues/139</a><br>[2] <a href="https://en.wikipedia.org/wiki/Federal_Information_Processing_Standards" target="_blank">https://en.wikipedia.org/wiki/<wbr>Federal_Information_<wbr>Processing_Standards</a><br>[3] <a href="http://cyan4973.github.io/xxHash/" target="_blank">http://cyan4973.github.io/<wbr>xxHash/</a><br>[4] <a href="https://review.gluster.org/#/c/17488/10" target="_blank">https://review.gluster.org/#/<wbr>c/17488/10</a><span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888"><br clear="all"></font></span></div></blockquote><div><br></div><div>Just one comment at the moment. Please separate out the patches as<br><br></div><div>1. changes to get xxHash into the project<br></div><div>2. gfid2path feature (which can use xxHash code).<br><br></div><div>That way it will be very easy to review, and also to maintain in future.<br><br></div><div>-Amar<br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="HOEnZb"><font color="#888888"><div><div><div><div><br>-- <br><div class="m_-8905746480029003095gmail_signature"><div dir="ltr"><div>Thanks and Regards,<br></div>Kotresh H R and Aravinda VK<br></div></div>
</div></div></div></div></font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div>