<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 23, 2017 at 7:24 PM, Shyam <span dir="ltr"><<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On 06/23/2017 09:48 AM, Pranith Kumar Karampuri wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
<br>
On Fri, Jun 23, 2017 at 7:06 PM, Shyam <<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a><br></span><div><div class="gmail-h5">
<mailto:<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>>> wrote:<br>
<br>
On 06/23/2017 07:00 AM, Pranith Kumar Karampuri wrote:<br>
<br>
Note that all of this is just my opinion, and based on<br>
working with many<br>
different projects that use git (or other tools) to identify<br>
patches<br>
that could be candidates for backporting. In general, the<br>
more details<br>
that are captured in the commit message, the easier it is to<br>
get an<br>
understanding of the different patches in different branches.<br>
<br>
<br>
Yes, I am also for as much information as possible in the commit<br>
with<br>
least amount of human effort. In time I would like us to get to<br>
a point,<br>
where we just have to say: backport release-3.12 release-3.11<br>
release-3.10 and the script should clone, send the patches on<br>
gerrit and<br>
do recheck centos, recheck netbsd, so the only human effort has<br>
to be to<br>
be merge the patch<br>
<br>
<br>
My opinion is that we should retain the information that we<br>
currently provide, for 2 reasons,<br>
<br>
1) Change-Id is gerrit specific, so if we move away at some later<br>
point in time, this is not going to help (yes we can search the git<br>
log for the same change ID etc. but as discussed in this thread, it<br>
is not git standard, it is gerrit addition)<br>
<br>
<br>
If we move away from gerrit the information we provide now about what is<br>
the patch on master etc are also not of any help.<br>
</div></div></blockquote>
<br>
Yes, but it is better to have this information at present than to drop it and loose the practice of providing the information.</blockquote><div><br></div><div>If we ensure that the link between different branches is taken care of. Answer to "Is it better to have this practice of providing information" is subjective. <br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Changing habits are hard, I would rather not change the habit at the moment.<span class="gmail-"></span></blockquote><div><br></div><div>I agree. It goes both ways, we will not force a habit on new contributors who are coming to the community this way. IMHO we can make it easier for someone to contribute to gluster by reducing manual steps. This is one such step if we can execute it right handling corner cases.<br></div><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
<br>
2) Using the same Change-Id is not enforced, so till we do that,<br>
getting to this point is not feasible.<br>
<br>
<br>
This is a valid point I think. But we can provide extra checks in smoke<br>
to check if it is not a backport with correct change-id. So it has solutions<br>
</blockquote>
<br></span>
Yes, this is pending to be done, <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1428047" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=1428047</a><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
<br>
Shyam<br>
<br>
<br>
<br><span class="gmail-HOEnZb"><font color="#888888">
<br>
--<br>
Pranith<br>
</font></span></blockquote>
</blockquote></div></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>