<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/23/2017 09:15 AM, Pranith Kumar
Karampuri wrote:<br>
</div>
<blockquote
cite="mid:CAOgeEna+SckO2haW9tLge-8Z1osKRwv_L1JAhMiQ5eX9B_qwvA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>hi,<br>
</div>
Now that we are doing backports with same Change-Id, we
can find the patches and their backports both online and in
the tree without any extra information in the commit message.
So shall we stop adding text similar to:<br>
<br>
> Reviewed-on: <a moz-do-not-send="true"
href="https://review.gluster.org/17414">https://review.gluster.org/17414</a><br>
</div>
</div>
</blockquote>
<br>
Sometimes I combine 2 commits from master (typically commit 2 which
fixes a bug in commit 1) in to a single patch while backporting. The
change ID is not the same in that case and I explicitly mention the
2 patch urls in the squashed commit sent to the release branch. So
in those cases, some way to trace back to the patches in master is
helpful. Otherwise I think it is fair to omit it.<br>
<br>
<blockquote
cite="mid:CAOgeEna+SckO2haW9tLge-8Z1osKRwv_L1JAhMiQ5eX9B_qwvA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div> > Smoke: Gluster Build System <<a
moz-do-not-send="true"
href="mailto:jenkins@build.gluster.org">jenkins@build.gluster.org</a>><br>
> Reviewed-by: Pranith Kumar Karampuri <<a
moz-do-not-send="true" href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a>><br>
> Tested-by: Pranith Kumar Karampuri <<a
moz-do-not-send="true" href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a>><br>
> NetBSD-regression: NetBSD Build System <<a
moz-do-not-send="true"
href="mailto:jenkins@build.gluster.org">jenkins@build.gluster.org</a>><br>
> Reviewed-by: Amar Tumballi <<a
moz-do-not-send="true" href="mailto:amarts@redhat.com">amarts@redhat.com</a>><br>
> CentOS-regression: Gluster Build System <<a
moz-do-not-send="true"
href="mailto:jenkins@build.gluster.org">jenkins@build.gluster.org</a>><br>
(cherry picked from commit
de92c363c95d16966dbcc9d8763fd4448dd84d13)<br>
</div>
<br>
in the patches?<br clear="all">
<div>
<div>
<div><br>
</div>
<div>Do you see any other value from this information that I
might be missing?<br>
<br>
</div>
<div>-- <br>
<div class="gmail_signature">
<div dir="ltr">Pranith<br>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="http://lists.gluster.org/mailman/listinfo/gluster-devel">http://lists.gluster.org/mailman/listinfo/gluster-devel</a></pre>
</blockquote>
<p><br>
</p>
</body>
</html>