<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 21, 2017 at 7:19 PM, Nigel Babu <span dir="ltr"><<a href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Jun 21, 2017 at 06:05:32PM +0530, Atin Mukherjee wrote:<br>
> On Tue, Jun 20, 2017 at 9:17 AM, Nigel Babu <<a href="mailto:nigelb@redhat.com">nigelb@redhat.com</a>> wrote:<br>
><br>
> > Hello folks,<br>
> ><br>
> > Amar has proposed[1] these changes in the past and I'd like to announce us<br>
> > going<br>
> > live with them as we've not received any strong feedback against it.<br>
> ><br>
> > ## Centos Regression<br>
> > * On master, we only run tests/basic as pre-merge testing.<br>
> ><br>
><br>
> I should have read this and Amar's email thread more carefully but<br>
> unfortunately I missed to read the above point in both the cases, so<br>
> apologies. I think running only tests/basic on master is not *sufficient*<br>
> given our goal is to have more test coverages coming from each patch and I<br>
> expect most of the patches if not all will have tests added and if we don't<br>
> run the full regression suite this eventually means we don't test the patch<br>
> on master. Also I'm not sure how reactive we are against the regression<br>
> test burn failure reports, so if things go bad and if we don't react to it<br>
> immediately it'd be difficult to get the master branch back to stable<br>
> state. I'd suggest (and request) that we should run the full regression<br>
> test suite on Centos.<br>
<br>
</span>These are valid concerns. I don't have an easy solution to any of them. So I've<br>
reverted the Centos regression changes entirely.<br></blockquote><div><br></div><div>Atin, thanks for highlighting it. Yes, I didn't foresee these issues when I proposed the changes.<br><br></div><div>With 'experimental' branch, which doesn't run regressions, the issue I was trying to make (Multiple smaller patchesets to complete a feature) gets solved. Hence keeping full regressions on master makes sense.<br><br></div><div>Thanks Nigel, for reverting back to normalcy quickly!<br><br></div><div>-Amar<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
> > * On release branches, we will run the entire suite of tests.<br>
> > * Our regular regression-test-burn-in and regression-test-with-multiplex<br>
> > will<br>
> > continue to run the full suite of tests as they currently do.<br>
> ><br>
> > ## NetBSD Regression<br>
> > * We will not run a netbsd7-regression as required pre-merge test anymore.<br>
> > However, you should be able to trigger it with "recheck netbsd".<br>
> > * A green NetBSD will no longer be required for merging patches, however<br>
> > if you<br>
> > have a -1 vote, it will remain a blocker. This is so that reviewers can<br>
> > request a full NetBSD run, especially on release branches.<br>
> > * We will do a periodic NetBSD regression run on all currently maintained<br>
> > branches (3.8, 3.10, and 3.11 at the moment) and master.<br>
> ><br>
> > ## Additional Changes<br>
> > * As full regression runs per patch is run on release branches only (other<br>
> > than<br>
> > the nightly on master), any failures need proper attention and possible<br>
> > RCA.<br>
> > A re-trigger in the hopes of getting a green is no longer acceptable for<br>
> > release branches.<br>
> > * fstat will soon track the regression-test-burn-in and<br>
> > regression-test-with-<wbr>multiplex.<br>
> > * As soon as we have the new jobs up, we'll add them to fstat so we can<br>
> > track<br>
> > failure patterns.<br>
> ><br>
> > The CentOS changes are already in production. The NetBSD changes will land<br>
> > in<br>
> > production today.<br>
> ><br>
> > [1]: <a href="http://lists.gluster.org/pipermail/gluster-devel/2017-May/052868.html" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>pipermail/gluster-devel/2017-<wbr>May/052868.html</a><br>
<br>
--<br>
nigelb<br>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div>