<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 23, 2017 at 9:55 AM, Pranith Kumar Karampuri <span dir="ltr"><<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Fri, Jun 23, 2017 at 9:37 AM, Ravishankar N <span dir="ltr"><<a href="mailto:ravishankar@redhat.com" target="_blank">ravishankar@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span>
<div class="m_-3037431997936614903m_8701541133633609073moz-cite-prefix">On 06/23/2017 09:15 AM, Pranith Kumar
Karampuri wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>hi,<br>
</div>
Now that we are doing backports with same Change-Id, we
can find the patches and their backports both online and in
the tree without any extra information in the commit message.
So shall we stop adding text similar to:<br>
<br>
> Reviewed-on: <a href="https://review.gluster.org/17414" target="_blank">https://review.gluster.org/174<wbr>14</a><br>
</div>
</div>
</blockquote>
<br></span>
Sometimes I combine 2 commits from master (typically commit 2 which
fixes a bug in commit 1) in to a single patch while backporting. The
change ID is not the same in that case and I explicitly mention the
2 patch urls in the squashed commit sent to the release branch. So
in those cases, some way to trace back to the patches in master is
helpful. Otherwise I think it is fair to omit it.<br></div></blockquote><div><br></div></span><div>Ah! makes sense. Maybe for exceptions, let us use this but as a rule maybe it doesn't seem like a bad idea to omit. Let us also hear from others.<br></div></div></div></div></blockquote><div><br></div><div>For easier one click approach, I guess, one can keep the 'Reviewed-on:' line with URL. All other info is just extra bytes IMO.<br><br></div><div>-Amar<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
<br>
<blockquote type="cite"><span>
<div dir="ltr">
<div> > Smoke: Gluster Build System <<a href="mailto:jenkins@build.gluster.org" target="_blank">jenkins@build.gluster.org</a>><br>
> Reviewed-by: Pranith Kumar Karampuri <<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>><br>
> Tested-by: Pranith Kumar Karampuri <<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>><br>
> NetBSD-regression: NetBSD Build System <<a href="mailto:jenkins@build.gluster.org" target="_blank">jenkins@build.gluster.org</a>><br>
> Reviewed-by: Amar Tumballi <<a href="mailto:amarts@redhat.com" target="_blank">amarts@redhat.com</a>><br>
> CentOS-regression: Gluster Build System <<a href="mailto:jenkins@build.gluster.org" target="_blank">jenkins@build.gluster.org</a>><br>
(cherry picked from commit
de92c363c95d16966dbcc9d8763fd4<wbr>448dd84d13)<br>
</div>
<br>
in the patches?<br clear="all">
<div>
<div>
<div><br>
</div>
<div>Do you see any other value from this information that I
might be missing?<br>
<br>
</div>
<div>-- <br>
<div class="m_-3037431997936614903m_8701541133633609073gmail_signature">
<div dir="ltr">Pranith<br>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="m_-3037431997936614903m_8701541133633609073mimeAttachmentHeader"></fieldset>
<br>
</span><pre>______________________________<wbr>_________________
Gluster-devel mailing list
<a class="m_-3037431997936614903m_8701541133633609073moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a>
<a class="m_-3037431997936614903m_8701541133633609073moz-txt-link-freetext" href="http://lists.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a></pre>
</blockquote>
<p><br>
</p>
</div>
</blockquote></span></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div class="m_-3037431997936614903gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</font></span></div></div>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div>