<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On 29 May 2017, at 11:16, Raghavendra G <<a href="mailto:raghavendra@gluster.com" class="">raghavendra@gluster.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class="">Replying to all queries here:<br class=""><br class=""></div>* Is it a bug or performance enhancement?<br class=""></div> Its a performance enhancement. No functionality is broken if this patch is not taken in.<br class=""><br class=""></div>* Are there performance numbers to validate the claim?<br class=""> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1358606#c9" class="">https://bugzilla.redhat.com/show_bug.cgi?id=1358606#c9</a><br class=""><br class=""></div>* Are there any existing users who need this enhancement?<br class=""> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1358606#c27" class="">https://bugzilla.redhat.com/show_bug.cgi?id=1358606#c27</a><br class=""><br class=""></div> Though not sure what branch Zhang Huan is on. @Zhang your inputs are needed here.<br class=""></div></div></div></div></div></div></blockquote><div><br class=""></div><div>We are currently on 3.8. Thus the performance number is based on 3.8.</div><div>If you need more details, please let me know.</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><div class=""><div class=""><div class=""><br class=""></div>* Do I think this patch _should_ go into any of the released branches?<br class=""></div> Personally, I don't feel strongly either way. I am fine with this patch not making into any of released branches. But, I do think there are users who are affected with this (Especially EC/Disperse configurations). If they want to stick to the released branches, pulling into released branches will help them. @Pranith/Xavi, what are your opinions on this?<br class=""><br class=""></div>regards,<br class=""></div>Raghavendra<br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sun, May 28, 2017 at 6:58 PM, Shyam <span dir="ltr" class=""><<a href="mailto:srangana@redhat.com" target="_blank" class="">srangana@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 05/28/2017 09:24 AM, Atin Mukherjee wrote:<br class="">
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br class="">
<br class="">
On Sun, May 28, 2017 at 1:48 PM, Niels de Vos <<a href="mailto:ndevos@redhat.com" target="_blank" class="">ndevos@redhat.com</a><br class=""></span><span class="">
<mailto:<a href="mailto:ndevos@redhat.com" target="_blank" class="">ndevos@redhat.com</a>>> wrote:<br class="">
<br class="">
On Fri, May 26, 2017 at 12:25:42PM -0400, Shyam wrote:<br class=""></span>
> Or this one: <a href="https://review.gluster.org/15036" rel="noreferrer" target="_blank" class="">https://review.gluster.org/150<wbr class="">36</a> <<a href="https://review.gluster.org/15036" rel="noreferrer" target="_blank" class="">https://review.gluster.org/15<wbr class="">036</a>><span class=""><br class="">
><br class="">
> This is backported to 3.8/10 and 3.11 and considering the size and impact of<br class="">
> the change, I wanted to be sure that we are going to accept this across all<br class="">
> 3 releases?<br class="">
><br class="">
> @Du, would like your thoughts on this.<br class="">
><br class="">
> @niels, @kaushal, @talur, as release owners, could you weigh in as well<br class="">
> please.<br class="">
><br class="">
> I am thinking that we get this into 3.11.1 if there is agreement, and not in<br class="">
> 3.11.0 as we are finalizing the release in 3 days, and this change looks<br class="">
> big, to get in at this time.<br class="">
<br class="">
<br class="">
Given 3.11 is going to be a new release, I'd recommend to get this fix<br class="">
in (if we have time). <a href="https://review.gluster.org/#/c/17402/" rel="noreferrer" target="_blank" class="">https://review.gluster.org/#/c<wbr class="">/17402/</a> is dependent<br class="">
on this one.<br class="">
</span></blockquote>
<br class="">
It is not a fix Atin, it is a more fundamental change to request processing, with 2 days to the release, you want me to merge this?<br class="">
<br class="">
Is there a *bug* that will surface without this change or is it a performance enhancement?<br class="">
<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br class="">
><br class="">
> Further the change is actually an enhancement, and provides performance<br class="">
> benefits, so it is valid as a change itself, but I feel it is too late to<br class="">
> add to the current 3.11 release.<br class="">
<br class="">
Indeed, and mostly we do not merge enhancements that are non-trivial to<br class="">
stable branches. Each change that we backport introduces the chance on<br class="">
regressions for users with their unknown (and possibly awkward)<br class="">
workloads.<br class="">
<br class="">
The patch itself looks ok, but it is difficult to predict how the change<br class="">
affects current deployments. I prefer to be conservative and not have<br class="">
this merged in 3.8, at least for now. Are there any statistics in how<br class="">
performance is affected with this change? Having features like this only<br class="">
in newer versions might also convince users to upgrade sooner, 3.8 will<br class="">
only be supported until 3.12 (or 4.0) gets released, which is approx. 3<br class="">
months from now according to our schedule.<br class="">
<br class="">
Niels<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
maintainers mailing list<br class=""></span>
<a href="mailto:maintainers@gluster.org" target="_blank" class="">maintainers@gluster.org</a> <mailto:<a href="mailto:maintainers@gluster.org" target="_blank" class="">maintainers@gluster.or<wbr class="">g</a>><br class="">
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank" class="">http://lists.gluster.org/mailm<wbr class="">an/listinfo/maintainers</a><br class="">
<<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank" class="">http://lists.gluster.org/mail<wbr class="">man/listinfo/maintainers</a>><br class="">
<br class="">
<br class="">
</blockquote><div class="HOEnZb"><div class="h5">
______________________________<wbr class="">_________________<br class="">
Gluster-devel mailing list<br class="">
<a href="mailto:Gluster-devel@gluster.org" target="_blank" class="">Gluster-devel@gluster.org</a><br class="">
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank" class="">http://lists.gluster.org/mailm<wbr class="">an/listinfo/gluster-devel</a><br class="">
</div></div></blockquote></div><br class=""><br clear="all" class=""><br class="">-- <br class=""><div class="gmail_signature" data-smartmail="gmail_signature">Raghavendra G<br class=""></div>
</div>
_______________________________________________<br class="">Gluster-devel mailing list<br class=""><a href="mailto:Gluster-devel@gluster.org" class="">Gluster-devel@gluster.org</a><br class="">http://lists.gluster.org/mailman/listinfo/gluster-devel</div></blockquote></div><br class=""></body></html>