<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 29, 2017 at 8:46 AM, Raghavendra G <span dir="ltr"><<a href="mailto:raghavendra@gluster.com" target="_blank">raghavendra@gluster.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div><div><div>Replying to all queries here:<br><br></div>* Is it a bug or performance enhancement?<br></div> Its a performance enhancement. No functionality is broken if this patch is not taken in.<br><br></div>* Are there performance numbers to validate the claim?<br> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1358606#c9" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1358606#c9</a><br><br></div>* Are there any existing users who need this enhancement?<br> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1358606#c27" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1358606#c27</a><br><br></div> Though not sure what branch Zhang Huan is on. @Zhang your inputs are needed here.<br><br></div>* Do I think this patch _should_ go into any of the released branches?<br></div> Personally, I don't feel strongly either way. I am fine with this patch not making into any of released branches. But, I do think there are users who are affected with this (Especially EC/Disperse configurations). If they want to stick to the released branches, pulling into released branches will help them. @Pranith/Xavi, what are your opinions on this?<br></div></div></div></blockquote><div><br></div><div>3.11.1 seems like a good idea IMO<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div>regards,<br></div>Raghavendra<br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Sun, May 28, 2017 at 6:58 PM, Shyam <span dir="ltr"><<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><span>On 05/28/2017 09:24 AM, Atin Mukherjee wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
<br>
<br>
On Sun, May 28, 2017 at 1:48 PM, Niels de Vos <<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a><br></span><span>
<mailto:<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>>> wrote:<br>
<br>
On Fri, May 26, 2017 at 12:25:42PM -0400, Shyam wrote:<br></span>
> Or this one: <a href="https://review.gluster.org/15036" rel="noreferrer" target="_blank">https://review.gluster.org/150<wbr>36</a> <<a href="https://review.gluster.org/15036" rel="noreferrer" target="_blank">https://review.gluster.org/15<wbr>036</a>><span><br>
><br>
> This is backported to 3.8/10 and 3.11 and considering the size and impact of<br>
> the change, I wanted to be sure that we are going to accept this across all<br>
> 3 releases?<br>
><br>
> @Du, would like your thoughts on this.<br>
><br>
> @niels, @kaushal, @talur, as release owners, could you weigh in as well<br>
> please.<br>
><br>
> I am thinking that we get this into 3.11.1 if there is agreement, and not in<br>
> 3.11.0 as we are finalizing the release in 3 days, and this change looks<br>
> big, to get in at this time.<br>
<br>
<br>
Given 3.11 is going to be a new release, I'd recommend to get this fix<br>
in (if we have time). <a href="https://review.gluster.org/#/c/17402/" rel="noreferrer" target="_blank">https://review.gluster.org/#/c<wbr>/17402/</a> is dependent<br>
on this one.<br>
</span></blockquote>
<br>
It is not a fix Atin, it is a more fundamental change to request processing, with 2 days to the release, you want me to merge this?<br>
<br>
Is there a *bug* that will surface without this change or is it a performance enhancement?<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
<br>
><br>
> Further the change is actually an enhancement, and provides performance<br>
> benefits, so it is valid as a change itself, but I feel it is too late to<br>
> add to the current 3.11 release.<br>
<br>
Indeed, and mostly we do not merge enhancements that are non-trivial to<br>
stable branches. Each change that we backport introduces the chance on<br>
regressions for users with their unknown (and possibly awkward)<br>
workloads.<br>
<br>
The patch itself looks ok, but it is difficult to predict how the change<br>
affects current deployments. I prefer to be conservative and not have<br>
this merged in 3.8, at least for now. Are there any statistics in how<br>
performance is affected with this change? Having features like this only<br>
in newer versions might also convince users to upgrade sooner, 3.8 will<br>
only be supported until 3.12 (or 4.0) gets released, which is approx. 3<br>
months from now according to our schedule.<br>
<br>
Niels<br>
<br>
______________________________<wbr>_________________<br>
maintainers mailing list<br></span>
<a href="mailto:maintainers@gluster.org" target="_blank">maintainers@gluster.org</a> <mailto:<a href="mailto:maintainers@gluster.org" target="_blank">maintainers@gluster.or<wbr>g</a>><br>
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/maintainers</a><br>
<<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/mail<wbr>man/listinfo/maintainers</a>><br>
<br>
<br>
</blockquote></div></div><div class="m_2550168884880547197HOEnZb"><div class="m_2550168884880547197h5">
______________________________<wbr>_________________<span class=""><br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><br>
</span></div></div></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div class="m_2550168884880547197gmail_signature" data-smartmail="gmail_signature">Raghavendra G<br></div>
</font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>