<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 24, 2017 at 7:16 PM, Shyam <span dir="ltr"><<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 05/24/2017 02:05 AM, Amar Tumballi wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Was looking at Milestone in Github:<br>
<a href="https://github.com/gluster/glusterfs/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22Release+3.11+%28STM%29%22" rel="noreferrer" target="_blank">https://github.com/gluster/glu<wbr>sterfs/issues?q=is%3Aopen+is%<wbr>3Aissue+milestone%3A%22Release<wbr>+3.11+%28STM%29%22</a><br>
<br>
It is still showing many things as open. I see some of them are done for<br>
sure. Please feel free to mark them as 'Closed'. Ideal to have commit id<br>
(from git log) while closing.<br>
</blockquote>
<br></span>
This is intentional Amar. The idea being once we have delivered all pieces we can mark if as closed.<br>
<br>
All pieces are design+code+documentation, IOW commits for gluster-specs, glusterfs, and release notes/glusterdocs commits.<br>
<br>
Once we have that in place, we can close the issue (even prior to the actual release). If not post the final release, I will cleanup the items in the lane as appropriate.<br>
<br>
Thoughts?<br></blockquote><div><br></div><div>Thanks for clarifying. I was thinking of PR / patch having 'fixes #NNN', which means automatically an issue would be closed. Hence the question.<br><br></div><div>Makes sense to keep it open if there is a piece pending from the feature, no issues there, rather that is the proper way.<br><br>+1.<br><br></div><div>Regards,<br></div><div>Amar<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
-Amar<br>
<br>
On Tue, May 23, 2017 at 7:43 PM, Shyam <<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a><br></span><div><div class="h5">
<mailto:<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>>> wrote:<br>
<br>
On 05/23/2017 09:27 AM, Shyam wrote:<br>
<br>
A note on release notes:<br>
<br>
1) release-notes are a part of the code repository, hence use<br>
gerrit to<br>
submit your changes to the release notes<br>
<br>
<br>
Here is an example: <a href="https://review.gluster.org/#/c/17372/" rel="noreferrer" target="_blank">https://review.gluster.org/#/c<wbr>/17372/</a><br>
<<a href="https://review.gluster.org/#/c/17372/" rel="noreferrer" target="_blank">https://review.gluster.org/#/<wbr>c/17372/</a>><br>
<br>
<br>
2) Also, as we use github for features, and most content that<br>
would be<br>
submitted to the release notes would be for features, use the<br>
same issue<br>
# as the code submission to submit the release notes changes as<br>
well.<br>
<br>
For example, to submit release notes for "Enhance handleops<br>
readdirplus<br>
operation to return handles along with dirents", use "Updates:<br>
#174" in<br>
the release notes commit message. There is *no* *need* for a BUG<br>
<br>
The advantages of this are that, we can track all submissions<br>
for said<br>
feature from the same issue in github (all submissions refers to<br>
feature-spec, code, release-notes, documentation changes).<br>
<br>
<br>
Here is how it gets reflected in the issue:<br>
<a href="https://github.com/gluster/glusterfs/issues/174#issuecomment-303403925" rel="noreferrer" target="_blank">https://github.com/gluster/glu<wbr>sterfs/issues/174#issuecomment<wbr>-303403925</a><br>
<<a href="https://github.com/gluster/glusterfs/issues/174#issuecomment-303403925" rel="noreferrer" target="_blank">https://github.com/gluster/gl<wbr>usterfs/issues/174#issuecommen<wbr>t-303403925</a>><br>
<br>
<br>
<br>
3) If a release-note is being added for a non-feature (say a warning<br>
about some feature, or that some functionality is still<br>
experimental,<br>
IOW things that do not have github issues), then use a bug for the<br>
submission as before.<br>
<br>
Thanks,<br>
Shyam<br>
<br>
"Releases are made better together"<br>
<br>
On 05/22/2017 09:37 PM, Shyam wrote:<br>
<br>
Hi,<br>
<br>
We just finished tagging release 3.11.0 RC1, that contains a<br>
few more<br>
fixes post 3.11.0 RC0.<br>
<br>
Packages for the same will be made available soon.<br>
<br>
*Attention* contributors:<br>
- We still are to see any updates to the release-notes<br>
[2], we have a<br>
week before the release, please update the release notes<br>
appropriately<br>
<br>
*Attention* all:<br>
- Any pending bugs that are critical to the release need<br>
to be marked<br>
as a blocker against [1] and we have about a week left to<br>
close out<br>
these bugs!<br>
<br>
Thanks,<br>
Shyam<br>
<br>
[1] Tracker BZ for 3.11.0 blockers:<br>
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=glusterfs-3.11.0" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=glusterfs-3.11.0</a><br>
<<a href="https://bugzilla.redhat.com/show_bug.cgi?id=glusterfs-3.11.0" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/s<wbr>how_bug.cgi?id=glusterfs-3.11.<wbr>0</a>><br>
<br>
[2] Release notes:<br>
<a href="https://github.com/gluster/glusterfs/blob/release-3.11/doc/release-notes/3.11.0.md" rel="noreferrer" target="_blank">https://github.com/gluster/glu<wbr>sterfs/blob/release-3.11/doc/<wbr>release-notes/3.11.0.md</a><br>
<<a href="https://github.com/gluster/glusterfs/blob/release-3.11/doc/release-notes/3.11.0.md" rel="noreferrer" target="_blank">https://github.com/gluster/gl<wbr>usterfs/blob/release-3.11/doc/<wbr>release-notes/3.11.0.md</a>><br>
<br>
<br>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br></div></div>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a> <mailto:<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.<wbr>org</a>><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><span class=""><br>
<<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mail<wbr>man/listinfo/gluster-devel</a>><br>
<br>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br></span>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a> <mailto:<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.<wbr>org</a>><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><span class=""><br>
<<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mail<wbr>man/listinfo/gluster-devel</a>><br>
<br>
<br>
<br>
<br>
--<br>
Amar Tumballi (amarts)<br>
</span></blockquote>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div>