<div dir="ltr"><div><div><div><div>Did get hold of all the pending patches till 2017-05-20 (660 in total). Note that it includes "All open" patches.<br><br></div>Attached is the file with all the details. Nigel, considering we have dump to have reference, can we go ahead and close everything which is 79 days old?<br><br></div>Let me know if anyone wants CSV output of the pending patches, and what all the info they need?<br><br></div><div>I recommend all the maintainers to go through the list and make sure they take appropriate action on all old patches. If people are lazy to go through all the patches, i can provide list of files changed per patch (url), so you can choose what matters to you.<br><br></div>Regards,<br></div>Amar<br><div><div><div><div><br></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 27, 2017 at 8:34 PM, Shyam <span dir="ltr"><<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 03/17/2017 03:22 AM, Nigel Babu wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello folks,<br>
<br>
I put this up for discussion at the last community meeting, but I was unable to<br>
attend the meeting. We have a lot of reviews that are quite old[1]. They have,<br>
at some point, become unmergable or the person who proposed them lost interest.<br>
This is on us. We've let reviews slip through the cracks. There are also the<br>
odd cases when a second patch has been merged which fixes the actual issue, but<br>
the old one isn't abandoned.<br>
<br>
There's no way we can work our way through the entire list. I suggest that we<br>
abandon all patches with no updates in the last 90 days. If it hits on a patch<br>
that someone is particularly passionate to get merged in, they're welcome to<br>
re-open it.<br>
</blockquote>
<br></span>
I agree with this, also it makes the dashboard more manageable.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
A. Current master dashboard: <a href="https://review.gluster.org/#/projects/glusterfs,dashboards/dashboard:master-dashboard" rel="noreferrer" target="_blank">https://review.gluster.org/#/p<wbr>rojects/glusterfs,dashboards/d<wbr>ashboard:master-dashboard</a><br>
B. Master dashboard (older than 90 days): <a href="http://bit.ly/2m8FX6m" rel="noreferrer" target="_blank">http://bit.ly/2m8FX6m</a><br>
C. Master dashboard (only patches newer than 90 days): <a href="http://bit.ly/2mB0xsl" rel="noreferrer" target="_blank">http://bit.ly/2mB0xsl</a><br>
<br>
If we abandon older patches, our master dashboard will look like (C) above.<br>
This means that there's already patches that are quite a few reviews that need<br>
some hand holding. Is it possible for us to catch up to the ones that are<br>
currently pending?<br>
</blockquote>
<br></span>
We should focus on getting things out of the way at least in 90 days, one way or the other. So, I would assume as we start using the dashboard, we will have better focus on the "Awaiting Reviews Or Regression" section as we go bottom up on that.<br>
<br>
So I would say we can catch up here (as in C), but not with B, so the overall idea seems to be useful to reduce noise at first, and possibly never get into this problem in the future as we catch up.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
[1]: <a href="http://bit.ly/2nfBq1N" rel="noreferrer" target="_blank">http://bit.ly/2nfBq1N</a><br>
<br>
--<br>
nigelb<br>
<br>
<br>
<br></span>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><br>
<br>
</blockquote>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div>