<div dir="ltr">Have just 1 comment. Once you answer it, its good to go.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 12, 2017 at 9:48 AM, Raghavendra G <span dir="ltr"><<a href="mailto:raghavendra@gluster.com" target="_blank">raghavendra@gluster.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'll wait for a day on this. If there are no reviews, I'll assume that as a +1 and will go ahead and merge it. If anyone needs more time, please let me know and I can wait.<br></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Thu, May 11, 2017 at 12:22 PM, Raghavendra Gowdappa <span dir="ltr"><<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">All,<br>
<br>
Reviews are requested on [1]. Impact is non-trivial as it introduces more concurrency in execution wrt processing of messages read from network.<br>
<br>
All tests are passed, though gerrit is not reflecting the last smoke which was successful.<br>
<br>
For reference, below is the verbatim copy of commit msg:<br>
<br>
<commit><br>
<br>
event/epoll: Add back socket for polling of events immediately after reading the entire rpc message from the wire Currently socket is added back for future events after higher layers (rpc, xlators etc) have processed the message. If message processing involves signficant delay (as in writev replies processed by Erasure Coding), performance takes hit. Hence this patch modifies transport/socket to add back the socket for polling of events immediately after reading the entire rpc message, but before notification to higher layers.<br>
<br>
credits: Thanks to "Kotresh Hiremath Ravishankar" <<a href="mailto:khiremat@redhat.com" target="_blank">khiremat@redhat.com</a>> for assitance in fixing a regression in bitrot caused by this patch.<br>
<br>
BUG: 1448364<br>
</commit><br>
<br>
@Nigel,<br>
<br>
Is there a way to override -1 from smoke, as last instance of it is successful?<br>
<br>
[1] <a href="https://review.gluster.org/#/c/15036/" rel="noreferrer" target="_blank">https://review.gluster.org/#/c<wbr>/15036/</a><br>
<br>
regards,<br>
Raghavendra<br>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><br>
</blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_9046723801627259727gmail_signature" data-smartmail="gmail_signature">Raghavendra G<br></div>
</font></span></div>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div>