<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 3, 2017 at 3:41 PM, Raghavendra Talur <span dir="ltr"><<a href="mailto:rtalur@redhat.com" target="_blank">rtalur@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Tue, May 2, 2017 at 8:46 PM, Nithya Balachandran <<a href="mailto:nbalacha@redhat.com">nbalacha@redhat.com</a>> wrote:<br>
><br>
><br>
> On 2 May 2017 at 16:59, Shyam <<a href="mailto:srangana@redhat.com">srangana@redhat.com</a>> wrote:<br>
>><br>
>> Talur,<br>
>><br>
>> Please wait for this fix before releasing 3.10.2.<br>
>><br>
>> We will take in the change to either prevent add-brick in<br>
>> sharded+distrbuted volumes, or throw a warning and force the use of --force<br>
>> to execute this.<br>
<br>
</span>Agreed, I have filed bug and marked as blocker for 3.10.2.<br>
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1447608" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1447608</a><br>
<span class="gmail-"><br>
<br>
>><br>
> IIUC, the problem is less the add brick operation and more the<br>
> rebalance/fix-layout. It is those that need to be prevented (as someone<br>
> could trigger those without an add-brick).<br>
<br>
</span>Yes, that problem seems to be with fix-layout/rebalance and not add-brick.<br>
However, depending on how users have arranged their dir structure, a<br>
add-brick without a fix-layout might be useless for them.<br>
<br>
I also had a look at the code to see if I can do the cli/glusterd<br>
change myself. However, sharding is enabled just as a xlator and not<br>
added to glusterd_volinfo_t.<br>
If someone from dht team could work with glusterd team here it would<br>
fix the issue faster.<br>
<br>
Action item on Nithya/Atin to assign bug 1447608 to someone. I will<br>
wait for the fix for 3.10.2.<br></blockquote><div><br></div><div>Fix is up @ <a href="https://review.gluster.org/#/c/17160/">https://review.gluster.org/#/c/17160/</a> . The only thing which we'd need to decide (and are debating on) is that should we bypass this validation with rebalance start force or not. What do others think?<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thanks,<br>
Raghavendra Talur<br>
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
><br>
> Nithya<br>
>><br>
>> Let's get a bug going, and not wait for someone to report it in bugzilla,<br>
>> and also mark it as blocking 3.10.2 release tracker bug.<br>
>><br>
>> Thanks,<br>
>> Shyam<br>
>><br>
>> On 05/02/2017 06:20 AM, Pranith Kumar Karampuri wrote:<br>
>>><br>
>>><br>
>>><br>
>>> On Tue, May 2, 2017 at 9:16 AM, Pranith Kumar Karampuri<br>
>>> <<a href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a> <mailto:<a href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a>>> wrote:<br>
>>><br>
>>> Yeah it is a good idea. I asked him to raise a bug and we can move<br>
>>> forward with it.<br>
>>><br>
>>><br>
>>> +Raghavendra/Nitya who can help with the fix.<br>
>>><br>
>>><br>
>>><br>
>>> On Mon, May 1, 2017 at 9:07 PM, Joe Julian <<a href="mailto:joe@julianfamily.org">joe@julianfamily.org</a><br>
>>> <mailto:<a href="mailto:joe@julianfamily.org">joe@julianfamily.org</a>>> wrote:<br>
>>><br>
>>><br>
>>> On 04/30/2017 01:13 AM, <a href="mailto:lemonnierk@ulrar.net">lemonnierk@ulrar.net</a><br>
>>> <mailto:<a href="mailto:lemonnierk@ulrar.net">lemonnierk@ulrar.net</a>> wrote:<br>
>>><br>
>>> So I was a little but luck. If I has all the hardware<br>
>>> part, probably i<br>
>>> would be firesd after causing data loss by using a<br>
>>> software marked as stable<br>
>>><br>
>>> Yes, we lost our data last year to this bug, and it wasn't a<br>
>>> test cluster.<br>
>>> We still hear from it from our clients to this day.<br>
>>><br>
>>> Is known that this feature is causing data loss and<br>
>>> there is no evidence or<br>
>>> no warning in official docs.<br>
>>><br>
>>> I was (I believe) the first one to run into the bug, it<br>
>>> happens and I knew it<br>
>>> was a risk when installing gluster.<br>
>>> But since then I didn't see any warnings anywhere except<br>
>>> here, I agree<br>
>>> with you that it should be mentionned in big bold letters on<br>
>>> the site.<br>
>>><br>
>>> Might even be worth adding a warning directly on the cli<br>
>>> when trying to<br>
>>> add bricks if sharding is enabled, to make sure no-one will<br>
>>> destroy a<br>
>>> whole cluster for a known bug.<br>
>>><br>
>>><br>
>>> I absolutely agree - or, just disable the ability to add-brick<br>
>>> with sharding enabled. Losing data should never be allowed.<br>
>>> ______________________________<wbr>_________________<br>
>>> Gluster-devel mailing list<br>
>>> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a> <mailto:<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.<wbr>org</a>><br>
>>> <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
>>> <<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><wbr>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Pranith<br>
>>><br>
>>> ______________________________<wbr>_________________<br>
>>> Gluster-users mailing list<br>
>>> <a href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.org</a> <mailto:<a href="mailto:Gluster-users@gluster.org">Gluster-users@gluster.<wbr>org</a>><br>
>>> <a href="http://lists.gluster.org/mailman/listinfo/gluster-users" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-users</a><br>
>>> <<a href="http://lists.gluster.org/mailman/listinfo/gluster-users" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-users</a><wbr>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Pranith<br>
>>><br>
>>><br>
>>> ______________________________<wbr>_________________<br>
>>> Gluster-devel mailing list<br>
>>> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
>>> <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
>>><br>
>> ______________________________<wbr>_________________<br>
>> Gluster-devel mailing list<br>
>> <a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
>> <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br>
><br>
><br>
</div></div></blockquote></div><br></div></div>