<div dir="ltr"><div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Mar 22, 2017 8:00 PM, <<a href="mailto:sriram@marirs.net.in" target="_blank">sriram@marirs.net.in</a>> wrote:<br type="attribution"><blockquote class="gmail-m_-6059612205908340181quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div><div>Hi Amar, <br></div><div class="gmail-m_-6059612205908340181quoted-text">
<div><br></div>
<div>On Wed, Mar 22, 2017, at 04:26 AM, Amar Tumballi wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div><div>Hi Sriram,<br></div>
</div>
<div>Thanks for sharing this. Just one comment below.<br></div>
<div><div><div><div><br></div>
<div><div>On Tue, Mar 21, 2017 at 10:12 AM, <span dir="ltr"><<a href="mailto:sriram@marirs.net.in" target="_blank">sriram@marirs.net.in</a>></span> wrote:<br></div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><u></u><br></div>
<div><div>Hi Raghavendra, <br></div>
<div><br></div>
<div>My name is Sriram I'd been working with Rajesh on creating a plugin structure for snapshot functionality. Below is the document which Rajesh'd created and I've edited the same with ideas and problems. Could you have a look and review so that we could take it forward? <br></div>
<div><br></div>
<div><a href="https://docs.google.com/document/d/1dHij_oy8V8CF2I7WfdYqKXFTGw0SKGzGlngDBpSwSGc/edit?usp=sharing" target="_blank">https://docs.google.com/docume<wbr>nt/d/1dHij_oy8V8CF2I7WfdYqKXFT<wbr>Gw0SKGzGlngDBpSwSGc/edit?usp=s<wbr>haring</a><br></div>
<div><br></div>
</div>
</blockquote><div><br></div>
<div><div>I am not sure if any 'code' has been written already for this. If not, great, because we want any improvements in 'glusterd' space to come through approval of new <a href="https://github.com/gluster/glusterd2/wiki/Design" target="_blank">GlusterD</a> design phase, so we can move away with the current glusterd.<br></div>
</div>
<div>But, looking at the design, the plugin can be pretty much be independent of the glusterd architecture, even then better to run it through everyone involved first.<br></div>
</div>
</div>
</div>
</div>
</div>
</blockquote><div><br></div>
</div><div>There was a series of patches which I'd sent initially but, then Rajesh and Avra proposed that we revisit the design once. So we'd stopped writing any code. <br></div>
<div><br></div>
<div><a href="https://review.gluster.org/#/c/16138/" target="_blank">https://review.gluster.org/#/c<wbr>/16138/</a> This was the series I'd posted. I'm not really sure who'd be helping on this activity to get them involved in the mail loop. I'll have a look at the GlusterD design phase approval wiki. Let me know as how we proceed on this. <br></div>
<div class="gmail-m_-6059612205908340181elided-text"><div></div><br></div><br></div>
</blockquote></div><br><div>I think the Snapshot plugin architecture can be more or less independent of
glusterd design. The snapshot management module which will interact with
glusterD should be aware of the new design. With new GlusterD design the existing snapshot code will any way need some refactoring. Therefore I think the new plugin architecture will help the future migration to new glusterd design. <br><br>It would be good if GlusterD team can aslo review the approach so that it will be in sync with the new design. Will be good to hear more from GlusterD team here.<br><br></div><div>-Rajesh<br></div></div></div></div>
</div>