<div dir="ltr"><div><div>Went through the code base again. Yes, as you said, we can get rid of fuse_getattr() not checking nodeid==1 path.<br><br></div>Patch here: <a href="https://review.gluster.org/16944">https://review.gluster.org/16944</a><br><br></div>-Amar<br><div><br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 24, 2017 at 2:57 AM, Zhitao Li <span dir="ltr"><<a href="mailto:zhitaoli1201@outlook.com" target="_blank">zhitaoli1201@outlook.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div id="m_1011345600268860472divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif" dir="ltr">
<p>Hello, everyone!</p>
<p><br>
</p>
<p>I am now optimizing the performance of "ls". <span style="font-size:12pt">When there are many little files directly </span><span style="font-size:12pt">in mount point(root dir of glusterfs</span><span style="font-size:12pt">)</span><span style="font-size:12pt">,
I find that fuse_getattr takes near half time of total </span><span style="font-size:12pt">"ls". Strictly, the nodeid==1 check in fuse_getattr will call look operation instead of stat, and lookup will always miss the md-cache, so it will do real lookup and
cost about 3ms a time in my case. </span></p>
<p><span style="font-size:12pt"><br>
</span></p>
<p>I doubt whether the special check of nodeid==1 is necessary. I disable the check, it works normal for ls. However, in the "tests" of gluster, it fails(quorum.t). In that case, lookup in root_dir is essential.</p>
<p><br>
</p>
<p>Up to now, we know that lookup bring high cost in fuse_getattr and it is essential in some case. Could anyone give some advice to improve fuse_getattr(lookup in root_dir) without bringing bugs? </p>
<p><br>
</p>
<p>I have been trying to deal with this for many days. Your help is greatly in need. </p>
<p><br>
</p>
<div id="m_1011345600268860472Signature">
<div style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif">
</div>
<div style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif">
Best regards,</div>
<div style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif">
Zhitao Li</div>
</div>
</div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div>