<div dir="ltr">Please check inline.<br><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 10, 2017 at 2:39 PM, Xavier Hernandez <span dir="ltr"><<a href="mailto:xhernandez@datalab.es" target="_blank">xhernandez@datalab.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
I'm looking at the locks xlator and I see that it has something called reserve locks. I remember long time ago that someone said this was defined for some purpose, but I don't remember and currently I'm unable to identify any place in the code where these locks are really used.<br>
<br>
I think it cannot be used from the user side through FUSE, maybe through gfapi it could be used.<br>
<br></blockquote><div><br></div><div>Not FUSE, Nor gfapi. This was added for supporting AFR's lock healing long back.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Only calls coming from the user can use it<br>
So the questions are:<br>
<br>
* Why are they needed ?<br></blockquote><div><br></div><div>"git show af18c636c44b1ea56296850e55afe0<wbr>e4b2ce845c" helped to understand the reason behind bring it in.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
* Are they being used for something ?<br></blockquote><div><br></div><div>This helped in opening and preserving the locks after healing a file which was open and had locks. Specially used in case of replace-brick type of operation.<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
* Can they be removed ?<br></blockquote><div><br></div><div>Current AFR maintainers should confirm about it as I haven't seen code in last 4yrs.<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thank you very much,<br>
<br>
Xavi<br>
______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/gluster-devel</a><br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="m_8921528298062607801gmail_signature"><div dir="ltr"><div class="m_8921528298062607801gmail_signature"><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div></div></div>