<div>I've +1ed it now.</div><div><br><div class="gmail_quote"><div>On Thu, 26 Jan 2017 at 15:05, Xavier Hernandez <<a href="mailto:xhernandez@datalab.es">xhernandez@datalab.es</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Atin,<br class="gmail_msg">
<br class="gmail_msg">
I don't clearly see what's the problem. Even if the truncate causes a<br class="gmail_msg">
dirty flag to be set, eventually it should be removed before the<br class="gmail_msg">
$HEAL_TIMEOUT value.<br class="gmail_msg">
<br class="gmail_msg">
For now I've marked the test as bad.<br class="gmail_msg">
<br class="gmail_msg">
Patch is: <a href="https://review.gluster.org/16470" rel="noreferrer" class="gmail_msg" target="_blank">https://review.gluster.org/16470</a><br class="gmail_msg">
<br class="gmail_msg">
Xavi<br class="gmail_msg">
<br class="gmail_msg">
On 25/01/17 17:24, Atin Mukherjee wrote:<br class="gmail_msg">
> Can we please address this as early as possible, my patch has hit this<br class="gmail_msg">
> failure 3 out of 4 recheck attempts now. I'm guessing some recent<br class="gmail_msg">
> changes has caused it.<br class="gmail_msg">
><br class="gmail_msg">
> On Wed, 25 Jan 2017 at 12:10, Ashish Pandey <<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a><br class="gmail_msg">
> <mailto:<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a>>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> Pranith,<br class="gmail_msg">
><br class="gmail_msg">
> In this test tests/basic/ec/ec-background-heals.t, I think the line<br class="gmail_msg">
> number 86 actually creating a heal entry instead of<br class="gmail_msg">
> helping data heal quickly. What if all the data was already healed<br class="gmail_msg">
> at that moment, truncate came and in preop set the dirty flag and at the<br class="gmail_msg">
> end, as part of the heal, dirty flag was unset on previous good<br class="gmail_msg">
> bricks only and the brick which acted as heal-sink still has dirty<br class="gmail_msg">
> marked by truncate.<br class="gmail_msg">
> That is why we are only seeing "1" as get_pending_heal_count. If a<br class="gmail_msg">
> file was actually not healed it should be "2".<br class="gmail_msg">
> If heal on this file completes and unset of dirty flag happens<br class="gmail_msg">
> before truncate everything will be fine.<br class="gmail_msg">
><br class="gmail_msg">
> I think we can wait for file to be heal without truncate?<br class="gmail_msg">
><br class="gmail_msg">
> 71 #Test that disabling background-heals still drains the queue<br class="gmail_msg">
> 72 TEST $CLI volume set $V0 disperse.background-heals 1<br class="gmail_msg">
> 73 TEST touch $M0/{a,b,c,d}<br class="gmail_msg">
> 74 TEST kill_brick $V0 $H0 $B0/${V0}2<br class="gmail_msg">
> 75 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT "1" mount_get_option_value<br class="gmail_msg">
> $M0 $V0-disperse-0 background-heals<br class="gmail_msg">
> 76 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT "200"<br class="gmail_msg">
> mount_get_option_value $M0 $V0-disperse-0 heal-wait-qlength<br class="gmail_msg">
> 77 TEST truncate -s 1GB $M0/a<br class="gmail_msg">
> 78 echo abc > $M0/b<br class="gmail_msg">
> 79 echo abc > $M0/c<br class="gmail_msg">
> 80 echo abc > $M0/d<br class="gmail_msg">
> 81 TEST $CLI volume start $V0 force<br class="gmail_msg">
> 82 EXPECT_WITHIN $CHILD_UP_TIMEOUT "3" ec_child_up_count $V0 0<br class="gmail_msg">
> 83 TEST chown root:root $M0/{a,b,c,d}<br class="gmail_msg">
> 84 TEST $CLI volume set $V0 disperse.background-heals 0<br class="gmail_msg">
> 85 EXPECT_NOT "0" mount_get_option_value $M0 $V0-disperse-0<br class="gmail_msg">
> heal-waiters<br class="gmail_msg">
><br class="gmail_msg">
> 86 TEST truncate -s 0 $M0/a # This completes the heal fast ;-) <<<<<<<<br class="gmail_msg">
><br class="gmail_msg">
> 87 EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0<br class="gmail_msg">
><br class="gmail_msg">
> ----<br class="gmail_msg">
> Ashish<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> ------------------------------------------------------------------------<br class="gmail_msg">
> *From: *"Raghavendra Gowdappa" <<a href="mailto:rgowdapp@redhat.com" class="gmail_msg" target="_blank">rgowdapp@redhat.com</a><br class="gmail_msg">
> <mailto:<a href="mailto:rgowdapp@redhat.com" class="gmail_msg" target="_blank">rgowdapp@redhat.com</a>>><br class="gmail_msg">
> *To: *"Nithya Balachandran" <<a href="mailto:nbalacha@redhat.com" class="gmail_msg" target="_blank">nbalacha@redhat.com</a><br class="gmail_msg">
> <mailto:<a href="mailto:nbalacha@redhat.com" class="gmail_msg" target="_blank">nbalacha@redhat.com</a>>><br class="gmail_msg">
> *Cc: *"Gluster Devel" <<a href="mailto:gluster-devel@gluster.org" class="gmail_msg" target="_blank">gluster-devel@gluster.org</a><br class="gmail_msg">
> <mailto:<a href="mailto:gluster-devel@gluster.org" class="gmail_msg" target="_blank">gluster-devel@gluster.org</a>>>, "Pranith Kumar Karampuri"<br class="gmail_msg">
> <<a href="mailto:pkarampu@redhat.com" class="gmail_msg" target="_blank">pkarampu@redhat.com</a> <mailto:<a href="mailto:pkarampu@redhat.com" class="gmail_msg" target="_blank">pkarampu@redhat.com</a>>>, "Ashish Pandey"<br class="gmail_msg">
> <<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a> <mailto:<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a>>><br class="gmail_msg">
> *Sent: *Wednesday, January 25, 2017 9:41:38 AM<br class="gmail_msg">
> *Subject: *Re: [Gluster-devel] Spurious regression<br class="gmail_msg">
> failure? tests/basic/ec/ec-background-heals.t<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> Found another failure on same test:<br class="gmail_msg">
> <a href="https://build.gluster.org/job/centos6-regression/2874/consoleFull" rel="noreferrer" class="gmail_msg" target="_blank">https://build.gluster.org/job/centos6-regression/2874/consoleFull</a><br class="gmail_msg">
><br class="gmail_msg">
> ----- Original Message -----<br class="gmail_msg">
> > From: "Nithya Balachandran" <<a href="mailto:nbalacha@redhat.com" class="gmail_msg" target="_blank">nbalacha@redhat.com</a><br class="gmail_msg">
> <mailto:<a href="mailto:nbalacha@redhat.com" class="gmail_msg" target="_blank">nbalacha@redhat.com</a>>><br class="gmail_msg">
> > To: "Gluster Devel" <<a href="mailto:gluster-devel@gluster.org" class="gmail_msg" target="_blank">gluster-devel@gluster.org</a><br class="gmail_msg">
> <mailto:<a href="mailto:gluster-devel@gluster.org" class="gmail_msg" target="_blank">gluster-devel@gluster.org</a>>>, "Pranith Kumar Karampuri"<br class="gmail_msg">
> <<a href="mailto:pkarampu@redhat.com" class="gmail_msg" target="_blank">pkarampu@redhat.com</a> <mailto:<a href="mailto:pkarampu@redhat.com" class="gmail_msg" target="_blank">pkarampu@redhat.com</a>>>, "Ashish Pandey"<br class="gmail_msg">
> > <<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a> <mailto:<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a>>><br class="gmail_msg">
> > Sent: Tuesday, January 24, 2017 9:16:31 AM<br class="gmail_msg">
> > Subject: [Gluster-devel] Spurious regression<br class="gmail_msg">
> failure? tests/basic/ec/ec-background-heals.t<br class="gmail_msg">
> ><br class="gmail_msg">
> > Hi,<br class="gmail_msg">
> ><br class="gmail_msg">
> ><br class="gmail_msg">
> > Can you please take a look at<br class="gmail_msg">
> > <a href="https://build.gluster.org/job/centos6-regression/2859/console" rel="noreferrer" class="gmail_msg" target="_blank">https://build.gluster.org/job/centos6-regression/2859/console</a> ?<br class="gmail_msg">
> ><br class="gmail_msg">
> > tests/basic/ec/ec-background-heals.t has failed.<br class="gmail_msg">
> ><br class="gmail_msg">
> > Thanks,<br class="gmail_msg">
> > Nithya<br class="gmail_msg">
> ><br class="gmail_msg">
> > _______________________________________________<br class="gmail_msg">
> > Gluster-devel mailing list<br class="gmail_msg">
> > <a href="mailto:Gluster-devel@gluster.org" class="gmail_msg" target="_blank">Gluster-devel@gluster.org</a> <mailto:<a href="mailto:Gluster-devel@gluster.org" class="gmail_msg" target="_blank">Gluster-devel@gluster.org</a>><br class="gmail_msg">
> > <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.gluster.org/mailman/listinfo/gluster-devel</a><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
><br class="gmail_msg">
> Gluster-devel mailing list<br class="gmail_msg">
><br class="gmail_msg">
> <a href="mailto:Gluster-devel@gluster.org" class="gmail_msg" target="_blank">Gluster-devel@gluster.org</a> <mailto:<a href="mailto:Gluster-devel@gluster.org" class="gmail_msg" target="_blank">Gluster-devel@gluster.org</a>><br class="gmail_msg">
><br class="gmail_msg">
> <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.gluster.org/mailman/listinfo/gluster-devel</a><br class="gmail_msg">
><br class="gmail_msg">
> --<br class="gmail_msg">
> - Atin (atinm)<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> Gluster-devel mailing list<br class="gmail_msg">
> <a href="mailto:Gluster-devel@gluster.org" class="gmail_msg" target="_blank">Gluster-devel@gluster.org</a><br class="gmail_msg">
> <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.gluster.org/mailman/listinfo/gluster-devel</a><br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature">- Atin (atinm)</div>