<div>Can we please address this as early as possible, my patch has hit this failure 3 out of 4 recheck attempts now. I&#39;m guessing some recent changes has caused it.</div><div><br><div class="gmail_quote"><div>On Wed, 25 Jan 2017 at 12:10, Ashish Pandey &lt;<a href="mailto:aspandey@redhat.com">aspandey@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_msg"><div style="font-family:times new roman,new york,times,serif;font-size:12pt;color:#000000" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Pranith,<br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">In this test tests/basic/ec/ec-background-heals.t, I think the line  number 86 actually creating a heal entry instead of <br class="gmail_msg"></div><div class="gmail_msg">helping data heal quickly. What if all the data was already healed at that moment, truncate came and in preop set the dirty flag and at the<br class="gmail_msg"></div><div class="gmail_msg">end, as part of the heal, dirty flag was unset on previous good bricks only and the brick which acted as heal-sink still has dirty marked by truncate.<br class="gmail_msg"></div><div class="gmail_msg">That is why we are only seeing &quot;1&quot; as get_pending_heal_count. If a file was actually not healed it should be &quot;2&quot;.<br class="gmail_msg"></div><div class="gmail_msg">If heal on this file completes and unset of dirty flag happens before truncate everything will be fine.<br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I think we can wait for file to be heal without truncate?</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"> 71 #Test that disabling background-heals still drains the queue<br class="gmail_msg"> 72 TEST $CLI volume set $V0 disperse.background-heals 1<br class="gmail_msg"> 73 TEST touch $M0/{a,b,c,d}<br class="gmail_msg"> 74 TEST kill_brick $V0 $H0 $B0/${V0}2<br class="gmail_msg"> 75 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT &quot;1&quot; mount_get_option_value $M0 $V0-disperse-0 background-heals<br class="gmail_msg"> 76 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT &quot;200&quot; mount_get_option_value $M0 $V0-disperse-0 heal-wait-qlength<br class="gmail_msg"> 77 TEST truncate -s 1GB $M0/a<br class="gmail_msg"> 78 echo abc &gt; $M0/b<br class="gmail_msg"> 79 echo abc &gt; $M0/c<br class="gmail_msg"> 80 echo abc &gt; $M0/d<br class="gmail_msg"> 81 TEST $CLI volume start $V0 force<br class="gmail_msg"> 82 EXPECT_WITHIN $CHILD_UP_TIMEOUT &quot;3&quot; ec_child_up_count $V0 0<br class="gmail_msg"> 83 TEST chown root:root $M0/{a,b,c,d}<br class="gmail_msg"> 84 TEST $CLI volume set $V0 disperse.background-heals 0<br class="gmail_msg"> 85 EXPECT_NOT &quot;0&quot; mount_get_option_value $M0 $V0-disperse-0 heal-waiters</div><div class="gmail_msg"><br class="gmail_msg"> 86 TEST truncate -s 0 $M0/a # This completes the heal fast ;-) &lt;&lt;&lt;&lt;&lt;&lt;&lt;<br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"> 87 EXPECT_WITHIN $HEAL_TIMEOUT &quot;^0$&quot; get_pending_heal_count $V0<br class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">----<br class="gmail_msg"></div><div class="gmail_msg">Ashish<br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div><hr id="m_-661458900338682261zwchr" class="gmail_msg"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt" class="gmail_msg"><b class="gmail_msg">From: </b>&quot;Raghavendra Gowdappa&quot; &lt;<a href="mailto:rgowdapp@redhat.com" class="gmail_msg" target="_blank">rgowdapp@redhat.com</a>&gt;<br class="gmail_msg"><b class="gmail_msg">To: </b>&quot;Nithya Balachandran&quot; &lt;<a href="mailto:nbalacha@redhat.com" class="gmail_msg" target="_blank">nbalacha@redhat.com</a>&gt;<br class="gmail_msg"><b class="gmail_msg">Cc: </b>&quot;Gluster Devel&quot; &lt;<a href="mailto:gluster-devel@gluster.org" class="gmail_msg" target="_blank">gluster-devel@gluster.org</a>&gt;, &quot;Pranith Kumar Karampuri&quot; &lt;<a href="mailto:pkarampu@redhat.com" class="gmail_msg" target="_blank">pkarampu@redhat.com</a>&gt;, &quot;Ashish Pandey&quot; &lt;<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a>&gt;<br class="gmail_msg"><b class="gmail_msg">Sent: </b>Wednesday, January 25, 2017 9:41:38 AM<br class="gmail_msg"><b class="gmail_msg">Subject: </b>Re: [Gluster-devel] Spurious regression failure?        tests/basic/ec/ec-background-heals.t</div></div></div><div class="gmail_msg"><div style="font-family:times new roman,new york,times,serif;font-size:12pt;color:#000000" class="gmail_msg"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt" class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div>Found another failure on same test:<br class="gmail_msg"><a href="https://build.gluster.org/job/centos6-regression/2874/consoleFull" class="gmail_msg" target="_blank">https://build.gluster.org/job/centos6-regression/2874/consoleFull</a><br class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div>----- Original Message -----<br class="gmail_msg">&gt; From: &quot;Nithya Balachandran&quot; &lt;<a href="mailto:nbalacha@redhat.com" class="gmail_msg" target="_blank">nbalacha@redhat.com</a>&gt;<br class="gmail_msg">&gt; To: &quot;Gluster Devel&quot; &lt;<a href="mailto:gluster-devel@gluster.org" class="gmail_msg" target="_blank">gluster-devel@gluster.org</a>&gt;, &quot;Pranith Kumar Karampuri&quot; &lt;<a href="mailto:pkarampu@redhat.com" class="gmail_msg" target="_blank">pkarampu@redhat.com</a>&gt;, &quot;Ashish Pandey&quot;<br class="gmail_msg">&gt; &lt;<a href="mailto:aspandey@redhat.com" class="gmail_msg" target="_blank">aspandey@redhat.com</a>&gt;<br class="gmail_msg">&gt; Sent: Tuesday, January 24, 2017 9:16:31 AM<br class="gmail_msg">&gt; Subject: [Gluster-devel] Spurious regression failure?        tests/basic/ec/ec-background-heals.t<br class="gmail_msg">&gt; <br class="gmail_msg">&gt; Hi,<br class="gmail_msg">&gt; <br class="gmail_msg">&gt; <br class="gmail_msg">&gt; Can you please take a look at<br class="gmail_msg">&gt; <a href="https://build.gluster.org/job/centos6-regression/2859/console" class="gmail_msg" target="_blank">https://build.gluster.org/job/centos6-regression/2859/console</a> ?<br class="gmail_msg">&gt; <br class="gmail_msg">&gt; tests/basic/ec/ec-background-heals.t has failed.<br class="gmail_msg">&gt; <br class="gmail_msg">&gt; Thanks,<br class="gmail_msg">&gt; Nithya<br class="gmail_msg">&gt; <br class="gmail_msg">&gt; _______________________________________________<br class="gmail_msg">&gt; Gluster-devel mailing list<br class="gmail_msg">&gt; <a href="mailto:Gluster-devel@gluster.org" class="gmail_msg" target="_blank">Gluster-devel@gluster.org</a><br class="gmail_msg">&gt; <a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" class="gmail_msg" target="_blank">http://lists.gluster.org/mailman/listinfo/gluster-devel</a><br class="gmail_msg"></div></div></div>_______________________________________________<br class="gmail_msg"><br>Gluster-devel mailing list<br class="gmail_msg"><br><a href="mailto:Gluster-devel@gluster.org" class="gmail_msg" target="_blank">Gluster-devel@gluster.org</a><br class="gmail_msg"><br><a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.gluster.org/mailman/listinfo/gluster-devel</a></blockquote></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature">- Atin (atinm)</div>