[Gluster-devel] Unable to send patches to release 3.7 branch.

[Niels de Vos]

On Fri, May 29, 2015 at 09:11:22AM +0530, Avra Sengupta wrote:
> Hi,
> 
> Usually when a patch is backported to release 3.7 branch it contains the
> following from the patch already merged in master:
> 
>     Change-Id: Ib878f39814af566b9250cf6b8ed47da0ca5b1128
>     BUG: 1226120
>     Signed-off-by: Avra Sengupta <asengupt at redhat.com>
>     Reviewed-on: http://review.gluster.org/10641
>     Reviewed-by: Rajesh Joseph <rjoseph at redhat.com>
>     Tested-by: NetBSD Build System
>     Reviewed-by: Kaushal M <kaushal at redhat.com>
> 
> While trying to send this patch from release 3.7 branch I am getting the
> following error from checkpatch.pl which is not letting me
> send the patch, and this is new because it didn't use to happen earlier.
> 
> # ./extras/checkpatch.pl
> 0001-glusterd-snapshot-Return-correct-errno-in-events-of-.patch
> Use of uninitialized value $gerrit_url in regexp compilation at
> ./extras/checkpatch.pl line 1958.
> ERROR: Unrecognized url address: 'http://review.gluster.org/10313'
> #16:
> Reviewed-on: http://review.gluster.org/10313
> 
> ERROR: Unrecognized email address: 'NetBSD Build System'
> #19:
> Tested-by: NetBSD Build System
> 
> Patch not according to coding guidelines! please fix.
> total: 2 errors, 0 warnings, 326 lines checked
> 
> Why is checkpatch unable to reference the gerrit url?

Maybe reformatting the commit message helps. I like to make it very
clear what was backported, and who reviewed/verified the backport.
Indenting all of that with "> " works for me, checkpatch.pl does not
complain about it.

For an example, see http://review.gluster.org/10882.

The backporting guidelines also describe this as well:

    http://www.gluster.org/community/documentation/index.php/Backport_Guidelines

Cheers,
Niels