[Gluster-devel] New Defects reported by Coverity Scan for gluster/glusterfs

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to gluster/glusterfs found with Coverity Scan.

33 new defect(s) introduced to gluster/glusterfs found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 33 defect(s)


** CID 1291734:  Error handling issues  (CHECKED_RETURN)
/xlators/cluster/dht/src/tier.c: 451 in tier_build_migration_qfile()


________________________________________________________________________________________________________
*** CID 1291734:  Error handling issues  (CHECKED_RETURN)
/xlators/cluster/dht/src/tier.c: 451 in tier_build_migration_qfile()
445     {
446             gfdb_time_t                     current_time;
447             _gfdb_brick_dict_info_t         gfdb_brick_dict_info;
448             gfdb_time_t                     time_in_past;
449             int                             ret = -1;
450     
>>>     CID 1291734:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "remove((is_promotion ? "/var/run/gluster/promotequeryfile" : "/var/run/gluster/demotequeryfile"))" without checking return value. This library function may fail and return an error code.
451             remove (GET_QFILE_PATH (is_promotion));
452             time_in_past.tv_sec = args->freq_time;
453             time_in_past.tv_usec = 0;
454             if (gettimeofday (&current_time, NULL) == -1) {
455                     gf_log (args->this->name, GF_LOG_ERROR,
456                             "Failed to get current timen");


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/987?tab=overview

To manage Coverity Scan email notifications for "gluster-devel at gluster.org", click https://scan.coverity.com/subscriptions/edit?email=gluster-devel%40gluster.org&token=7dffab14bc5a7180e75b0d047539f148 .