[Gluster-devel] Setting up git / gerrit / rfc.sh

[John Smith]

Hi,

Thanks, both. I did indeed not do 'git commit -s', and after adding signed
off with git commit --amend, rfc.sh worked.

http://review.gluster.org/#/c/5034/


Regards,


John Smith.



On Sun, May 19, 2013 at 3:11 AM, Michael Brown <michael at netdirect.ca> wrote:

> .. and to fix it, do: 'git commit --amend' and add the appropriate
> Signed-off-by: as you see in other commits in the repo.
>
> M.
>
> --
> Michael Brown | `One of the main causes of the fall of
> Systems Consultant | the Roman Empire was that, lacking zero,
> Net Direct Inc. | they had no way to indicate successful
> ☎: +1 519 883 1172 x5106 | termination of their C programs.' - Firth
>   *From: *Justin Clift
> *Sent: *Saturday, May 18, 2013 21:06
> *To: *John Smith
> *Reply To: *Justin Clift
> *Cc: *Gluster Devel
> *Subject: *Re: [Gluster-devel] Setting up git / gerrit / rfc.sh
>
> On 19/05/2013, at 5:03 AM, John Smith wrote:
> <snip>
> > ! [remote rejected] HEAD -> refs/for/master/bug-962226 (not
> > Signed-off-by author/committer/uploader in commit message footer)
>
> The "not Signed-off-by xxx" bit sounds like the problem. Guess you
> forgot to do a "signed commit" instead of normal commit?
>
> ie:
>
> $ git commit -s
>
> instead of
>
> $ git commit
>
> + Justin
>
> --
> Open Source and Standards @ Red Hat
>
> twitter.com/realjustinclift
>
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at nongnu.org
> https://lists.nongnu.org/mailman/listinfo/gluster-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://supercolony.gluster.org/pipermail/gluster-devel/attachments/20130519/922eb4ab/attachment-0001.html>