[Gluster-devel] glfs_init() not setting errno when volfile server is invalid

[Amar Tumballi]

On 08/02/2012 10:42 AM, Bharata B Rao wrote:
> On Thu, Aug 2, 2012 at 8:16 AM, Anand Avati <anand.avati at gmail.com> wrote:
>> I think this was fixed in http://review.gluster.com/#change,3732. Can you
>> confirm?
>
> That commit doesn't fix this issue. I still see glfs_init() returning
> -1 with errno=0 when an invalid server is specified.
>

will below patch fix the issue? (very hacky, but prevents the qemu crash 
i guess)


diff --git a/api/src/glfs.c b/api/src/glfs.c
index e81ae56..fecefea 100644
--- a/api/src/glfs.c
+++ b/api/src/glfs.c
@@ -530,6 +530,9 @@ glfs_init (struct glfs *fs)

         ret = glfs_init_wait (fs);

+        if (ret && !errno)
+                errno = EINVAL;
+
         return ret;
  }


> Regards,
> Bharata.
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at nongnu.org
> https://lists.nongnu.org/mailman/listinfo/gluster-devel
>