[Bugs] [Bug 1658742] New: Inconsistent type for 'remote-port' parameter

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1658742

            Bug ID: 1658742
           Summary: Inconsistent type for 'remote-port' parameter
           Product: GlusterFS
           Version: mainline
            Status: NEW
         Component: rpc
          Severity: low
          Assignee: bugs at gluster.org
          Reporter: ykaul at redhat.com
                CC: bugs at gluster.org
  Target Milestone: ---
    Classification: Community



Description of problem:
It seems to be set as int32, and read as uint16.

Elsewhere, it is used as a string, which is even stranger, btw.

It should be consistent.

For example:
api/src/glfs-mgmt.c:923:                    ret =
dict_set_int32(rpc_trans->options, "remote-port",
rpc/rpc-transport/socket/src/name.c:242:        remote_port =
data_to_uint16(remote_port_data);
rpc/rpc-transport/rdma/src/name.c:245:            remote_port =
data_to_uint16(remote_port_data);
rpc/rpc-lib/src/rpc-transport.c:684:    ret = dict_set_int32(dict,
"remote-port", port);

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.