[Bugs] [Bug 1184885] Quota: Build ancestry in the lookup

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 1 06:38:47 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1184885



--- Comment #17 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9954 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 3d4203fe3acad47f0a29ebe094b3e427b13f363f
Author: vmallika <vmallika at redhat.com>
Date:   Fri Mar 20 14:25:58 2015 +0530

    quota: enhancement of build ancestry

    There can a small race window where marker accounting will
    be missed.
    Consider below example where NFS mount is used
    and bricks are restarted and a write operation is performed

    Currently:
    T1: lookup from protocol server, quota will initiate ancestry build
    T2: opendir FOP from ancestry build
    T3: write FOP from client
    T4: write_cbk
    T5: marker initiate accounting.
        There will be a problem here and txn aborts,
        because build_ancestry is not complete
        and parent not found for an inode
    T6: opendir_cbk
    T7: initiate readdirp, posix builds ancestry in readdirp


    With this patch, now calling readdirp on anonoymous fd
    during build ancestry:

    T1: lookup from protocol server, quota will initiate ancestry build
    T2: readirp FOP from ancestry build, posix builds ancestry in
        readdirp
    T3: write FOP from client
    T4: write_cbk
    T5: marker initiate accounting.
        No problem here as build ancestry was performed at T1


    Change-Id: I2c262c86f34f6c574940a6b8772d94f2bade9465
    BUG: 1184885
    Signed-off-by: vmallika <vmallika at redhat.com>
    Reviewed-on: http://review.gluster.org/9954
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>
    Tested-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3zCHvgDmcA&a=cc_unsubscribe


More information about the Bugs mailing list