<div dir="ltr"><div dir="ltr">We can check using below command before submitting patch<br><br>#flake8 <test_script.py></div><div dir="ltr"><br></div><div>or</div><div><br></div><div>#flake8 <path_to_directory><br></div><div dir="ltr"><br></div><div>Regards,</div><div>Vijay A<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 29, 2019 at 11:17 AM Yaniv Kaul <<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 29, 2019 at 8:38 AM Vijay Bhaskar Reddy Avuthu <<a href="mailto:vavuthu@redhat.com" target="_blank">vavuthu@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div>Thanks Yaniv for pointing out the typos. We follow flake8 and pylint. <br></div>As soon as patch is submitted, Gluster Build System will run both flake8 and pylint. If it fails Build System will give -1<br></div>Before merging the patch, we run the test case in upstream through "/run tests"<br></div></div></div></blockquote><div><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Thanks.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Is there a simple way to apply the same flake8 and pylint rules on your code, before submitting a patch?</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">I see there's a .pylintrc in the repository, any instructions for flake8?<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">TIA,</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Y.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div>Regards,<br></div>Vijay A<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 28, 2019 at 7:24 PM Yaniv Kaul <<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">1. There are several typos in the messages. Would be nice to fix (I'll send a patch to those I stumble upon)</div><div style="font-family:arial,helvetica,sans-serif">2. Do we have some code convention? Flake8, pep8, pylint?</div><div style="font-family:arial,helvetica,sans-serif">3. Is there some CI, to ensure changes do not break tests?</div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">TIA,</div><div style="font-family:arial,helvetica,sans-serif">Y.<br></div></div>
_______________________________________________<br>
automated-testing mailing list<br>
<a href="mailto:automated-testing@gluster.org" target="_blank">automated-testing@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/automated-testing" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/automated-testing</a><br>
</blockquote></div>
</blockquote></div></div>
</blockquote></div>