<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 28, 2019 at 7:21 PM Jonathan Holloway <<a href="mailto:jholloway@redhat.com">jholloway@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Only where a mount is exec'd in setUp. In some cases, tests are grouped by Class with the volume created in setUp without a mount. Any tests requiring a mount handle the mount and subsequent umount before tearDown gets run.</div><div><br></div><div>e.g.,</div><div><span class="gmail-m_7327874995707908277gmail-pl-en">test_volume_create_start_stop_start() is only testing the volume and doesn't require the mount, whereas...</span></div><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en">test_file_dir_create_ops_on_volume() is creating ops on the mounted volume and does it's own mount/umount.</span></span></div></div></blockquote><div><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">(It's also taking 100% CPU during execution, need to find out why...)</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en"><br></span></span></div><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en">This file could be
broken into a volume only class and a mounted volume class to handle the
mount/umount in tearDown, or even allow the super GlusterBaseClass.tearDownClass()
method do it automatically.</span></span></span></span></div></div></blockquote><div><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Ok, so since for some reason test_volume_sanity() is failing for me[2], it doesn't unmount.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Unmount before making the check, so it'll clean well, even if it fails seem to help[3].<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en"><br></span></span></div><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en">On another note, this test_vvt.py test can probably be eliminated with the code covered in another volume test suite (or suites) and the volume verification test step in BVT run using pytest markers against @pytest.mark.bvt_vvt decorator as I'd originally intended.</span></span></div><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en">The idea there was to create a BVT test from a sample of existing testcases written in the full test suites--eliminating duplication of code.<br></span></span></div></div></blockquote><div><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">This is what is running today (I think) in upstream[1], so if it needs to / can be, that'd be great, but has to be coordinated.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Y.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">[1] <a href="https://github.com/gluster/glusterfs-patch-acceptance-tests/blob/b9e7dbc57bc96c8a538593f7a5ff0f03fc38e335/centos-ci/scripts/run-glusto.sh">https://github.com/gluster/glusterfs-patch-acceptance-tests/blob/b9e7dbc57bc96c8a538593f7a5ff0f03fc38e335/centos-ci/scripts/run-glusto.sh</a><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">[2] Donno what it means:</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">E AssertionError: Lists are not equal.<br>E Before creating file: ['00\nchangelogs\nindices\nlandfill\nunlink\n', '00\nchangelogs\nindices\nlandfill\nunlink\n', '00\nchangelogs\nindices\nlandfill\nunlink\n', '00\nchangelogs\nindices\nlandfill\nunlink\n']<br>E After deleting file: ['00\nchangelogs\nindices\nlandfill\nunlink\n', '00\nchangelogs\nindices\nlandfill\nunlink\n', '00\n25\nchangelogs\nindices\nlandfill\nunlink\n', '00\n25\n2d\nchangelogs\nindices\nlandfill\nunlink\n']<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">[3] <a href="https://review.gluster.org/#/c/glusto-tests/+/22440/">https://review.gluster.org/#/c/glusto-tests/+/22440/</a><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en"></span></span></div><div><span class="gmail-m_7327874995707908277gmail-pl-en"><span class="gmail-m_7327874995707908277gmail-pl-en"><br></span></span></div><div>Cheers,</div><div>Jonathan<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 28, 2019 at 9:02 AM Yaniv Kaul <<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">Teardown (at least where I'm looking at, test_vvt.py) is cleaning up the volume.</div><div style="font-family:arial,helvetica,sans-serif">Shouldn't it also unmount the client?</div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">TIA,</div><div style="font-family:arial,helvetica,sans-serif">Y.<br></div></div>
_______________________________________________<br>
automated-testing mailing list<br>
<a href="mailto:automated-testing@gluster.org" target="_blank">automated-testing@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/automated-testing" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/automated-testing</a><br>
</blockquote></div>
</blockquote></div></div></div></div></div></div>