<div dir="ltr"><div>We can definitely mark the tests with a pytest marker and run with the -m <gcs_marker_name>. If pytest provides a mechanism to show which marker was used to kick off the tests, we should be able to add logic to the GlusterBaseClass.runs_on to alter the list for GCS runs. Worst case, we could include a var in the config file (or elsewhere) to act as a flag.<br><br></div>--Jonathan<br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 5, 2018 at 4:29 AM Nigel Babu <<a href="mailto:nigelb@redhat.com">nigelb@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I don't think we're in a place to branch at the moment.</div><div><br></div><div>The right way to branch would be to have the libraries split off from the glusto-tests repo into its own independent repo that we can version. Then we'd have a version of the library that works for GD2 and a version of the library that works for GD1. The tests should continue to remain the same. If the tests need changing, that means an incompatibility has slipped in. However, the tests that are critical for GCS should be marked with a PyTest flag so we can only run those tests when we want to. This is way more tricky than it sounds, because not all volume types are supported in GCS.</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 4, 2018 at 5:09 PM Rahul Hinduja <<a href="mailto:rhinduja@redhat.com" target="_blank">rhinduja@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Wed 4 Jul, 2018, 5:04 PM Vijay Bhaskar Reddy Avuthu, <<a href="mailto:vavuthu@redhat.com" target="_blank">vavuthu@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hi All,<br><br>This thread is regarding the support of GD2 with "glusto-tests". <br></div><div><br></div><div>Since we are fastly moving towards GCS/RHOCS which mainly build on GD2, we need to work towards supporting both GD2 and GD1.<br><br>Here are few thoughts:<br><br>1) Identify GD2 is running or not, then according we need modify libraries/tests to support latest command<br><br>eg:<br><br>new cmd : <br><br>glustercli volume start <testvol><br>or<br>curl -X POST <a href="http://192.168.56.101:24007/v1/volumes/testvol/start" rel="noreferrer" target="_blank">http://192.168.56.101:24007/v1/volumes/testvol/start</a><br><br><br>In lib below is the modification snippet:<br><br>if glusterd2_enable():<br> glustercli volume start <testvol><br>else:<br> gluster volume start <testvol><br><br>For above approach, needs lot of re-work.<br><br>2) Versioning ?<br><br>not sure how versioning works<br><br>Any other thoughts whats is the best way to support both GD2 and GD1 ?<br></div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Gil had suggested branching and I echo that. </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div>Regards,<br></div>Vijay A<br></div>
</blockquote></div></div></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_-47961120018179732gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">nigelb<br></div></div>
</blockquote></div>